[ruff] Handle unary operators in decimal-from-float-literal (RUF032)#13275
Merged
AlexWaygood merged 4 commits intoastral-sh:mainfrom Sep 7, 2024
Merged
[ruff] Handle unary operators in decimal-from-float-literal (RUF032)#13275AlexWaygood merged 4 commits intoastral-sh:mainfrom
ruff] Handle unary operators in decimal-from-float-literal (RUF032)#13275AlexWaygood merged 4 commits intoastral-sh:mainfrom
Conversation
decimal-from-float-literal (RUF032)ruff] Handle unary operators in decimal-from-float-literal (RUF032)
Contributor
|
AlexWaygood
approved these changes
Sep 7, 2024
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks! I pushed a commit to reduce the amount of cloning of AST nodes, which can be quite expensive. I also made a few other small simplifications -- let me know if you have any questions about the changes I pushed!
Collaborator
Author
|
I was wondering how to do something like that, so that's super helpful to see - thanks for making the code much nicer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that the suggested "stringified" float passed to
decimal.Decimaldoes not contain more than one unary operator, and that the rule ignores floats with the invalid unary operators~andnot. For example,has a suggested fix of
Decimal("-4.0").Closes #13258