Mark sys.version_info[0] < 3 and similar comparisons as outdated#13175
Merged
charliermarsh merged 1 commit intomainfrom Aug 30, 2024
Merged
Mark sys.version_info[0] < 3 and similar comparisons as outdated#13175charliermarsh merged 1 commit intomainfrom
sys.version_info[0] < 3 and similar comparisons as outdated#13175charliermarsh merged 1 commit intomainfrom
Conversation
charliermarsh
commented
Aug 30, 2024
| checker.diagnostics.push(diagnostic); | ||
| let reason = match (int.as_u8(), op) { | ||
| (Some(2), CmpOp::Eq) => Reason::AlwaysFalse, | ||
| (Some(3), CmpOp::Eq) => Reason::AlwaysTrue, |
Member
Author
There was a problem hiding this comment.
== 3 is maybe a little dubious, but we were already doing it. (== is the only case we handled before.)
CodSpeed Performance ReportMerging #13175 will degrade performances by 7.61%Comparing Summary
Benchmarks breakdown
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #12993.