[flake8-pyi] Respect pep8_naming.classmethod-decorators settings when determining if a method is a classmethod in custom-type-var-return-type (PYI019)#13162
Merged
AlexWaygood merged 1 commit intomainfrom Aug 30, 2024
Conversation
…when determining if a method is a classmethod in `custom-type-var-return-type` (`PYI019`)
charliermarsh
approved these changes
Aug 30, 2024
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that
PYI019was using its own routines for determining whether a function was a classmethod or not, when most of our linter rules useruff_python_semantic::function_type::classify()for this purpose. Using the common method inPYI019means that this rule will benefit from any bugfixes we make toclassify()in the future, and also means that this rule now respects thepep8_naming.classmethod-decoratorssetting when deciding whether a method is a classmethod or not.Test Plan
cargo test -p ruff_linter