Consider with blocks as single-item branches#12311
Merged
charliermarsh merged 1 commit intomainfrom Jul 13, 2024
Merged
Conversation
3d3d968 to
79cfeee
Compare
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| F811 | 4 | 0 | 4 | 0 | 0 |
| RUF100 | 1 | 1 | 0 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+1 -4 violations, +0 -0 fixes in 4 projects; 50 projects unchanged)
fronzbot/blinkpy (+0 -2 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
- blinksync/blinksync.py:58:53: F811 Redefinition of unused `working` from line 55 - blinksync/blinksync.py:81:53: F811 Redefinition of unused `working` from line 78
prefecthq/prefect (+0 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
- src/prefect/cli/cloud/__init__.py:266:42: F811 Redefinition of unused `timeout_scope` from line 241
encode/httpx (+0 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
- tests/client/test_auth.py:371:73: F811 Redefinition of unused `client` from line 366
mesonbuild/meson-python (+1 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ tests/test_editable.py:287:30: RUF100 [*] Unused `noqa` directive (unused: `F811`)
Changes by rule (2 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| F811 | 4 | 0 | 4 | 0 | 0 |
| RUF100 | 1 | 1 | 0 | 0 | 0 |
Member
Author
|
Ecosystem checks are generally improvements. This one is debatable though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensures that, e.g., the following is not considered a redefinition-without-use:
Closes #12309.