Use more threads when discovering python files#12258
Merged
MichaReiser merged 3 commits intomainfrom Jul 10, 2024
Merged
Conversation
MichaReiser
commented
Jul 9, 2024
Comment on lines
+382
to
+387
| builder.threads( | ||
| std::thread::available_parallelism() | ||
| .map_or(1, std::num::NonZero::get) | ||
| .min(12), | ||
| ); | ||
|
|
Member
Author
There was a problem hiding this comment.
New default for the number of threads
313f839 to
7a29294
Compare
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
ignorecrates defaults to two threads when usingbuild_parallel. This PR adopts a simplified heuristic from ripgrep to get a "good" number of threads to use. This gives me on my machine a 25% boost when checking an already cached project.I also refactored the visitor to use a custom visitor builder.
That allows us to push to local
Vecand only merging them when the visitor gets dropped.I hoped for a more significant speedup than 0-1%. I don't mind reverting that change.
Test Plan
ruff-main: Baseline of this PRruff: This PRruff-fn: This PR but without using a custom visitor builder