[flake8-async] Update ASYNC100 to match upstream#12221
Merged
charliermarsh merged 4 commits intoastral-sh:mainfrom Jul 9, 2024
Merged
[flake8-async] Update ASYNC100 to match upstream#12221charliermarsh merged 4 commits intoastral-sh:mainfrom
flake8-async] Update ASYNC100 to match upstream#12221charliermarsh merged 4 commits intoastral-sh:mainfrom
Conversation
MichaReiser
approved these changes
Jul 8, 2024
Member
MichaReiser
left a comment
There was a problem hiding this comment.
Awesome, thank you!
I think we should gate this change behind preview because it changes the scope of the rule.
Contributor
Author
|
Not super straight forward to gate since it's just detecting a few additional context managers. I think there's precedence for not gating when just detecting more functions, e.g., #12065 |
Member
|
The way this differs in my view from the numpy rule is that the NumPy rule was made more complete by including more of the deprecated methods. This PR introduces support for entire new async libraries, which extends the scope of the rule. @zanieb what's your take on this? |
Contributor
Author
|
Ok no problem. I did the gating. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the name of
ASYNC100to match upstream.Also update to the functionality to match upstream by supporting additional context managers from asyncio and anyio. Matching this list.
Part of #12039.
Test Plan
Added the new context managers to the fixture.