feat(rules): detect httpx for S113#12174
Conversation
charliermarsh
left a comment
There was a problem hiding this comment.
Thanks -- this looks good to me!
|
Not sure a missing timeout is a problem since |
|
httpx has default timeout, this PR would be a false positive https://www.python-httpx.org/advanced/timeouts/
|
Indeed, really sorry for missing that obvious information, I should have better checked that. |
|
false positive fix #12213 |
Summary
Bandit now also reports
B113onhttpx(PyCQA/bandit#1060). This PR implements the same logic, to detect missing orNonetimeouts forhttpxalongsiderequests.Test Plan
Snapshot tests.