Skip to content

Make requires-python inference robust to ==#12091

Merged
charliermarsh merged 1 commit intomainfrom
charlie/detect
Jun 28, 2024
Merged

Make requires-python inference robust to ==#12091
charliermarsh merged 1 commit intomainfrom
charlie/detect

Conversation

@charliermarsh
Copy link
Copy Markdown
Member

@charliermarsh charliermarsh commented Jun 28, 2024

Summary

Instead of using a high patch version, attempt to detect the minimum-supported minor.

Closes #12088.

@charliermarsh charliermarsh requested a review from konstin June 28, 2024 12:08
@charliermarsh charliermarsh added the bug Something isn't working label Jun 28, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 28, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

demisto/content (error) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
  - 'ignore' -> 'lint.ignore'
  - 'select' -> 'lint.select'
  - 'unfixable' -> 'lint.unfixable'
  - 'per-file-ignores' -> 'lint.per-file-ignores'
warning: `PGH001` has been remapped to `S307`.
warning: `PGH002` has been remapped to `G010`.
warning: `PLR1701` has been remapped to `SIM101`.
ruff failed
  Cause: Selection of deprecated rule `E999` is not allowed when preview is enabled.

@charliermarsh charliermarsh merged commit c326778 into main Jun 28, 2024
@charliermarsh charliermarsh deleted the charlie/detect branch June 28, 2024 13:38
@BrewTestBot BrewTestBot mentioned this pull request Jul 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@konstin konstin konstin approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UP006 Do not work if requires-python = "== 3.11" in pyproject.toml

2 participants

@charliermarsh @konstin