ruff server: An empty code action filter no longer returns notebook source actions#11526
Merged
snowsignal merged 2 commits intomainfrom May 24, 2024
Merged
Conversation
Contributor
|
dhruvmanila
approved these changes
May 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11516
ruff serverwas sending both regular source actions and notebook source actions back when passed an empty action filter. This PR makes a few small changes so that notebook source actions are not sent when regular source actions are sent, which means that an empty filter will only return regular source actions.Test Plan
I confirmed that duplicate code actions no longer appeared in Neovim, using a configuration similar to the one from the original issue.