[flake8-logging-format] Fix the autofix title in logging-warn (G010)#11514
Merged
dhruvmanila merged 2 commits intoastral-sh:mainfrom May 24, 2024
Merged
[flake8-logging-format] Fix the autofix title in logging-warn (G010)#11514dhruvmanila merged 2 commits intoastral-sh:mainfrom
flake8-logging-format] Fix the autofix title in logging-warn (G010)#11514dhruvmanila merged 2 commits intoastral-sh:mainfrom
Conversation
Contributor
|
dhruvmanila
approved these changes
May 24, 2024
Member
dhruvmanila
left a comment
There was a problem hiding this comment.
Thank you!
I apologize for not being able to properly test this at the moment, the change was made by grepping the repo and fixing the typo in code as well as in the .snap file.
Well, the CI is green so everything must have been updated ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rule
logging-warn(G010) prescribes a change fromwarntowarningand has a corresponding autofix, but the autofix is mistakenly titled"Convert to `warn`"instead of"Convert to `warning`"(the latter is what the autofix actually does). Seems to be a plain typo.Test Plan
I apologize for not being able to properly test this at the moment, the change was made by grepping the repo and fixing the typo in code as well as in the
.snapfile.