Improve ruff_python_semantic::all::extract_all_names()#11335
Merged
AlexWaygood merged 3 commits intomainfrom May 8, 2024
Merged
Improve ruff_python_semantic::all::extract_all_names()#11335AlexWaygood merged 3 commits intomainfrom
ruff_python_semantic::all::extract_all_names()#11335AlexWaygood merged 3 commits intomainfrom
Conversation
Contributor
|
MichaReiser
approved these changes
May 8, 2024
Member
Author
FWIW this does have a small user-visible impact ( |
AlexWaygood
commented
May 8, 2024
MichaReiser
approved these changes
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following 22639c5, this function now lives in the
ruff_python_semanticcrate. That means we can simplify the function's signature: where previously it required a closure to be passed in, we can now simply pass in a reference to aSemanticModelinstance. As well as simplifying the signature of the function, this also means we can make the function more accurate: it now recognises__all__ = builtins.list(["foo", "bar"])as a valid__all__definition, as well as__all__ = list(["foo", "bar"]).Test Plan
I added a new pyflakes fixture.
cargo test/cargo insta review.