Skip to content

Allow set(True) for boolean traps#11287

Merged
charliermarsh merged 1 commit intomainfrom
charlie/fbt
May 4, 2024
Merged

Allow set(True) for boolean traps#11287
charliermarsh merged 1 commit intomainfrom
charlie/fbt

Conversation

@charliermarsh
Copy link
Copy Markdown
Member

Closes #8923.

@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label May 4, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) May 4, 2024 21:26
@charliermarsh charliermarsh merged commit c3e0306 into main May 4, 2024
@charliermarsh charliermarsh deleted the charlie/fbt branch May 4, 2024 21:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 4, 2024

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+0 -3 violations, +0 -0 fixes in 1 projects; 43 projects unchanged)

apache/airflow (+0 -3 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --no-preview --select ALL

- airflow/jobs/triggerer_job_runner.py:596:29: FBT003 Boolean positional value in function call
- airflow/jobs/triggerer_job_runner.py:599:31: FBT003 Boolean positional value in function call
- airflow/jobs/triggerer_job_runner.py:635:29: FBT003 Boolean positional value in function call

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
FBT003 3 0 3 0 0

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -3 violations, +0 -0 fixes in 1 projects; 43 projects unchanged)

apache/airflow (+0 -3 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

- airflow/jobs/triggerer_job_runner.py:596:29: FBT003 Boolean positional value in function call
- airflow/jobs/triggerer_job_runner.py:599:31: FBT003 Boolean positional value in function call
- airflow/jobs/triggerer_job_runner.py:635:29: FBT003 Boolean positional value in function call

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
FBT003 3 0 3 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

boolean-positional-value-in-call (FBT003) - don't warn when function name starts with set_ and only takes one argument

1 participant