ruff server respects per-file-ignores configuration#11224
Merged
snowsignal merged 1 commit intomainfrom May 2, 2024
Merged
Conversation
Contributor
|
charliermarsh
approved these changes
May 1, 2024
MichaReiser
approved these changes
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11185
Fixes #11214
Document path and package information is now forwarded to the Ruff linter, which allows
per-file-ignoresto correctly match against the file name. This also fixes an issue where the import sorting rule didn't distinguish between third-party and first-party packages since we didn't pass in the package root.Test Plan
per-file-ignoresshould ignore files as expected. One quick way to check is by adding this to yourpyproject.toml:Then, confirm that no diagnostics appear when you add code to an
__init__.pyfile (besides syntax errors).The import sorting fix can be verified by failing to reproduce the original issue - an
I001diagnostic should not appear inother_module.py.