[flake8-blind-expect] Allow raise from in BLE001#11131
Merged
charliermarsh merged 1 commit intoastral-sh:mainfrom Apr 24, 2024
Merged
[flake8-blind-expect] Allow raise from in BLE001#11131charliermarsh merged 1 commit intoastral-sh:mainfrom
flake8-blind-expect] Allow raise from in BLE001#11131charliermarsh merged 1 commit intoastral-sh:mainfrom
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| BLE001 | 14 | 2 | 12 | 0 | 0 |
| RUF100 | 8 | 8 | 0 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+11 -13 violations, +0 -0 fixes in 4 projects; 40 projects unchanged)
PlasmaPy/PlasmaPy (+6 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ src/plasmapy/formulary/collisions/helio/collisional_analysis.py:238:9: PLR0917 Too many positional arguments (12/5) - src/plasmapy/formulary/collisions/helio/collisional_analysis.py:238:9: PLR0917 Too many positional arguments (12/5) + src/plasmapy/formulary/collisions/helio/collisional_analysis.py:355:29: RUF100 [*] Unused `noqa` directive (unused: `BLE001`) + tests/dispersion/test_dispersion_functions.py:122:35: RUF100 [*] Unused `noqa` directive (unused: `BLE001`) + tests/particles/conftest.py:19:31: RUF100 [*] Unused `noqa` directive (unused: `BLE001`) + tests/particles/test_particle_class.py:530:31: RUF100 [*] Unused `noqa` directive (unused: `BLE001`) + tests/particles/test_particle_class.py:912:31: RUF100 [*] Unused `noqa` directive (unused: `BLE001`)
apache/airflow (+0 -11 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
- airflow/kubernetes/pre_7_4_0_compatibility/pod_generator.py:464:16: BLE001 Do not catch blind exception: `Exception` - airflow/kubernetes/pre_7_4_0_compatibility/pod_generator.py:472:20: BLE001 Do not catch blind exception: `Exception` - airflow/operators/python.py:782:20: BLE001 Do not catch blind exception: `Exception` - airflow/providers/alibaba/cloud/hooks/analyticdb_spark.py:104:16: BLE001 Do not catch blind exception: `Exception` - airflow/providers/alibaba/cloud/hooks/analyticdb_spark.py:126:16: BLE001 Do not catch blind exception: `Exception` - airflow/providers/alibaba/cloud/hooks/analyticdb_spark.py:143:16: BLE001 Do not catch blind exception: `Exception` - airflow/providers/alibaba/cloud/hooks/analyticdb_spark.py:160:16: BLE001 Do not catch blind exception: `Exception` - airflow/providers/alibaba/cloud/hooks/analyticdb_spark.py:179:16: BLE001 Do not catch blind exception: `Exception` - airflow/providers/alibaba/cloud/hooks/analyticdb_spark.py:192:16: BLE001 Do not catch blind exception: `Exception` - airflow/providers/cncf/kubernetes/pod_generator.py:454:16: BLE001 Do not catch blind exception: `Exception` - airflow/providers/cncf/kubernetes/pod_generator.py:462:20: BLE001 Do not catch blind exception: `Exception`
ibis-project/ibis (+3 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ ibis/backends/__init__.py:54:35: RUF100 Unused `noqa` directive (unused: `BLE001`) + ibis/backends/__init__.py:62:35: RUF100 Unused `noqa` directive (unused: `BLE001`) + ibis/examples/__init__.py:171:29: RUF100 Unused `noqa` directive (unused: `BLE001`)
zulip/zulip (+2 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
+ scripts/lib/setup_venv.py:344:16: BLE001 Do not catch blind exception: `BaseException` + tools/lib/provision.py:385:20: BLE001 Do not catch blind exception: `BaseException` - zproject/backends.py:1031:16: BLE001 Do not catch blind exception: `Exception`
Changes by rule (3 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| BLE001 | 14 | 2 | 12 | 0 | 0 |
| RUF100 | 8 | 8 | 0 | 0 | 0 |
| PLR0917 | 2 | 1 | 1 | 0 | 0 |
flake8-blind-expect] Allow raise from in BLE001
wilbrdt
added a commit
to openfun/ralph
that referenced
this pull request
Apr 29, 2024
`flake8-blind-except` from Ruff now allows to raise from a broad exception, making the escapes unused directives (see astral-sh/ruff#11131). Removing unused directives.
wilbrdt
added a commit
to openfun/ralph
that referenced
this pull request
Apr 30, 2024
`flake8-blind-except` from Ruff now allows to raise from a broad exception, making the escapes unused directives (see astral-sh/ruff#11131). Removing unused directives.
wilbrdt
added a commit
to openfun/ralph
that referenced
this pull request
Apr 30, 2024
`flake8-blind-except` from Ruff now allows to raise from a broad exception, making the escapes unused directives (see astral-sh/ruff#11131). Removing unused directives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This allows
raise fromin BLE001.Fixes #10806
Test Plan
Test case added.