[pylint] Implement invalid-index-returned (PLE0305)#10962
Merged
charliermarsh merged 7 commits intoastral-sh:mainfrom Apr 19, 2024
Merged
[pylint] Implement invalid-index-returned (PLE0305)#10962charliermarsh merged 7 commits intoastral-sh:mainfrom
pylint] Implement invalid-index-returned (PLE0305)#10962charliermarsh merged 7 commits intoastral-sh:mainfrom
Conversation
This was referenced Apr 15, 2024
CodSpeed Performance ReportMerging #10962 will not alter performanceComparing Summary
|
Contributor
|
1a265f0 to
f025b0d
Compare
charliermarsh
pushed a commit
that referenced
this pull request
Apr 18, 2024
Add pylint rule invalid-length-returned (PLE0303) See #970 for rules Test Plan: `cargo test` TBD: from the description: "Strictly speaking `bool` is a subclass of `int`, thus returning `True`/`False` is valid. To be consistent with other rules (e.g. [PLE0305](#10962) invalid-index-returned), ruff will raise, compared to pylint which will not raise."
8704a3f to
04fe643
Compare
04fe643 to
98865bf
Compare
charliermarsh
pushed a commit
that referenced
this pull request
Apr 19, 2024
Add pylint rule invalid-hash-returned (PLE0309) See #970 for rules Test Plan: `cargo test` TBD: from the description: "Strictly speaking `bool` is a subclass of `int`, thus returning `True`/`False` is valid. To be consistent with other rules (e.g. [PLE0305](#10962) invalid-index-returned), ruff will raise, compared to pylint which will not raise."
pylint] Implement invalid-index-returned (PLE0305)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pylint rule invalid-index-returned (PLE0305)
See #970 for rules
Test Plan:
cargo testTBD: from the description: "Note: Strictly speaking
boolis a subclass ofint, thus returningTrue/Falseis valid. However, a DeprecationWarning (DeprecationWarning: __index__ returned non-int (type bool)) for such cases was already introduced, thus this is a conscious difference between the original pylint rule and the current ruff implementation."