[refurb] Implement fstring-number-format (FURB116)#10921
Merged
charliermarsh merged 6 commits intoastral-sh:mainfrom Apr 26, 2024
Merged
[refurb] Implement fstring-number-format (FURB116)#10921charliermarsh merged 6 commits intoastral-sh:mainfrom
refurb] Implement fstring-number-format (FURB116)#10921charliermarsh merged 6 commits intoastral-sh:mainfrom
Conversation
Contributor
Author
|
Not too sure how I'd reliably be able to support expressions that can include strings, such as calls, like in my |
Contributor
|
diceroll123
commented
Apr 14, 2024
Comment on lines
+106
to
+112
| let Expr::Name(ast::ExprName { id, .. }) = func.as_ref() else { | ||
| return; | ||
| }; | ||
|
|
||
| if !checker.semantic().is_builtin(id) { | ||
| return; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
If #10919 is merged before this, I'll update accordingly.
dbf8213 to
b623a80
Compare
refurb] - add fstring-number-format with sometimes-autofix (FURB116)refurb] Implement fstring-number-format (FURB116)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
FURB116See #1348
Test Plan
cargo test