[flake8-slots] Flag subclasses of call-based typing.NamedTuples as well as subclasses of collections.namedtuple() (SLOT002)#10808
Merged
AlexWaygood merged 1 commit intoastral-sh:mainfrom Apr 6, 2024
Conversation
…s well as subclasses of `collections.namedtuple()` (`SLOT002`)
Contributor
|
charliermarsh
approved these changes
Apr 6, 2024
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
Apr 12, 2024
…s well as subclasses of `collections.namedtuple()` (`SLOT002`) (astral-sh#10808)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10805.
While
__slots__are automatically added to this class by thetypingmodule......they are not automatically added to this class...
...so it seems reasonable for
SLOT002to emit a lint on that class just the same as it does for this class:Test Plan
cargo test