Skip to content

[pylint] Implement bad-staticmethod-argument (PLW0211)#10781

Merged
charliermarsh merged 3 commits intoastral-sh:mainfrom
augustelalande:bad-staticmethod-argument
Apr 5, 2024
Merged

[pylint] Implement bad-staticmethod-argument (PLW0211)#10781
charliermarsh merged 3 commits intoastral-sh:mainfrom
augustelalande:bad-staticmethod-argument

Conversation

@augustelalande
Copy link
Contributor

Summary

Implement bad-staticmethod-argument from pylint, part of #970.

Test Plan

Text fixture added.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+2 -0 violations, +0 -0 fixes in 2 projects; 42 projects unchanged)

apache/airflow (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ tests/secrets/test_cache.py:43:25: PLW0211 First argument of a static method should not be named `self`

indico/indico (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ indico/web/http_api/hooks/base.py:78:18: PLW0211 First argument of a static method should not be named `cls`

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
PLW0211 2 2 0 0 0

@augustelalande augustelalande force-pushed the bad-staticmethod-argument branch from ba8c9e0 to 93ff635 Compare April 4, 2024 23:13
@charliermarsh charliermarsh self-requested a review April 5, 2024 21:14
@charliermarsh charliermarsh self-assigned this Apr 5, 2024
@charliermarsh charliermarsh added rule Implementing or modifying a lint rule preview Related to preview mode features labels Apr 5, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) April 5, 2024 21:25
@charliermarsh charliermarsh merged commit c2790f9 into astral-sh:main Apr 5, 2024
@charliermarsh
Copy link
Member

Thanks!

@augustelalande augustelalande deleted the bad-staticmethod-argument branch April 5, 2024 22:10
Glyphack pushed a commit to Glyphack/ruff that referenced this pull request Apr 12, 2024
…sh#10781)

## Summary

Implement `bad-staticmethod-argument` from pylint, part of astral-sh#970.

## Test Plan

Text fixture added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview Related to preview mode features rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants