[refurb] Implement unnecessary-from-float (FURB164)#10647
Merged
charliermarsh merged 7 commits intoastral-sh:mainfrom Mar 30, 2024
Merged
[refurb] Implement unnecessary-from-float (FURB164)#10647charliermarsh merged 7 commits intoastral-sh:mainfrom
refurb] Implement unnecessary-from-float (FURB164)#10647charliermarsh merged 7 commits intoastral-sh:mainfrom
Conversation
Member
|
Maybe |
Contributor
|
Contributor
Author
|
I have thought of that, but should we incorporate |
Contributor
Author
|
Also I'm not very sure why |
Member
|
It sometimes has this error. Let me re-run it to see if it resolves the issue. |
| /// Decimal(4.2) | ||
| /// Decimal("inf") | ||
| /// Fraction(4.2) | ||
| /// Fraction(Decimal("4.2")) |
Member
There was a problem hiding this comment.
Should the inner "4.2" be 4.2?
refurb] Implement verbose-decimal-fraction-construction (FURB164)refurb] Implement unnecessary-from-float (FURB164)
c0db3d9 to
20223cb
Compare
auto-merge was automatically disabled
March 30, 2024 10:50
Head branch was pushed to by a user without write access
Contributor
Author
|
Sorry for the late response and thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement FURB164 in the issue #1348.
Relevant Refurb docs is here: https://github.com/dosisod/refurb/blob/v2.0.0/docs/checks.md#furb164-no-from-float
I've changed the name from
no-from-floattoverbose-decimal-fraction-construction.Test Plan
I've written it in the
FURB164.py.