Avoid failures due to non-deterministic binding ordering#10478
Merged
charliermarsh merged 1 commit intomainfrom Mar 19, 2024
Merged
Avoid failures due to non-deterministic binding ordering#10478charliermarsh merged 1 commit intomainfrom
charliermarsh merged 1 commit intomainfrom
Conversation
Member
Author
|
Would also be solved by #10479. |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We're seeing failures in #10470 because
resolve_qualified_import_nameisn't guaranteed to return a specific import if a symbol is accessible in two ways (e.g., you have bothimport loggingandfrom logging import errorin scope, and you wantlogging.error). This PR breaks up the failing tests such that the imports aren't in the same scope.Closes #10470.
Test Plan
I added a
bindings.reverse()toresolve_qualified_import_nameto ensure that the tests pass regardless of the binding order.