Avoid removing shadowed imports that point to different symbols#10387
Merged
charliermarsh merged 1 commit intomainfrom Mar 13, 2024
Merged
Avoid removing shadowed imports that point to different symbols#10387charliermarsh merged 1 commit intomainfrom
charliermarsh merged 1 commit intomainfrom
Conversation
Contributor
|
Member
|
@charliermarsh you merge machine — why not #10388? doesn't it make more sense to remove the first import? |
Member
Author
|
I explained a bit in the PR summary why that isn't really ideal. These are typically going to be "the same" import anyway so this felt ok to me. |
Member
|
Hm okay, can revisit later if we need to. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that we don't have incorrect, automated fixes for shadowed names that actually point to different imports.
See: #10384.