Skip to content

Avoid TRIO115 if the argument is a variable#10376

Merged
dhruvmanila merged 1 commit intoastral-sh:mainfrom
augustelalande:trio115-false-positive
Mar 13, 2024
Merged

Avoid TRIO115 if the argument is a variable#10376
dhruvmanila merged 1 commit intoastral-sh:mainfrom
augustelalande:trio115-false-positive

Conversation

@augustelalande
Copy link
Contributor

Summary

Fix "TRIO115 false positive with with sleep(var) where var starts as 0" #9935 based on the discussion in the issue.

Test Plan

Issue code added to fixture

@github-actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhruvmanila dhruvmanila added the bug Something isn't working label Mar 13, 2024
@dhruvmanila dhruvmanila changed the title Fix TRIO115 false positive #9935 Avoid TRIO115 if the argument is a variable Mar 13, 2024
@dhruvmanila dhruvmanila merged commit 93d582d into astral-sh:main Mar 13, 2024
@augustelalande augustelalande deleted the trio115-false-positive branch March 13, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants