[pycodestyle] Implement redundant-backslash (E502)#10292
Merged
charliermarsh merged 5 commits intoastral-sh:mainfrom Mar 12, 2024
Merged
[pycodestyle] Implement redundant-backslash (E502)#10292charliermarsh merged 5 commits intoastral-sh:mainfrom
pycodestyle] Implement redundant-backslash (E502)#10292charliermarsh merged 5 commits intoastral-sh:mainfrom
Conversation
pycodestyle] Implement redundant-backslash (E502`)pycodestyle] Implement redundant-backslash (E502)
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| E502 | 4 | 4 | 0 | 0 | 0 |
Formatter (stable)
✅ ecosystem check detected no format changes.
Formatter (preview)
✅ ecosystem check detected no format changes.
| } | ||
| cursor += c.len_utf8(); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
We have a struct called Indexer that already stores the locations of all continuations (i.e., the line positions following a \). I'm wondering if we could instead iterate over the token stream, identify parenthesized ranges, and then search for continuation_lines offsets within parenthesized ranges?
charliermarsh
approved these changes
Mar 12, 2024
Member
charliermarsh
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me.
Contributor
|
One more step towards #9057 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the redundant-backslash rule (E502) from pycodestyle.
Test Plan
New fixture has been added
Part of #2402