Skip to content

Bump version to v0.1.12#9475

Merged
charliermarsh merged 9 commits intomainfrom
charlie/bump
Jan 11, 2024
Merged

Bump version to v0.1.12#9475
charliermarsh merged 9 commits intomainfrom
charlie/bump

Conversation

@charliermarsh
Copy link
Copy Markdown
Member

@charliermarsh charliermarsh commented Jan 11, 2024

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 11, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -4 violations, +0 -0 fixes in 1 projects; 42 projects unchanged)

pandas-dev/pandas (+0 -4 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview

- pandas/core/internals/construction.py:161:5: PLR0917 Too many positional arguments (6/5)
- pandas/core/internals/construction.py:237:5: PLR0917 Too many positional arguments (6/5)
- pandas/core/internals/construction.py:441:9: PLC0415 `import` should be at the top-level of a file
- pandas/core/internals/construction.py:784:5: PLC0415 `import` should be at the top-level of a file

Changes by rule (2 rules affected)

code total + violation - violation + fix - fix
PLR0917 2 0 2 0 0
PLC0415 2 0 2 0 0

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@charliermarsh charliermarsh marked this pull request as ready for review January 11, 2024 19:50
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jan 11, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9475 will degrade performances by 4.35%

Comparing charlie/bump (97702d9) with main (eb4ed24)

Summary

❌ 1 regressions
✅ 29 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main charlie/bump Change
❌ parser[numpy/ctypeslib.py] 12.2 ms 12.8 ms -4.35%

AlexWaygood
AlexWaygood reviewed Jan 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions ;)

Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment on lines +20 to +21
- [\`flake8-bugbear\`] Include subscripts and attributes in static key rule ([#9416](https://github.com/astral-sh/ruff/pull/9416))
- [\`flake8-bugbear\`] Support variable keys in static dictionary key rule ([#9411](https://github.com/astral-sh/ruff/pull/9411))
Copy link
Copy Markdown
Member

@AlexWaygood AlexWaygood Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these are both changes to RUF011 -- is it correct to classify them as flake8-bugbear?

Copy link
Copy Markdown
Member Author

@charliermarsh charliermarsh Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks. This rule was moved to flake8-bugbear, but that PR hasn't actually merged yet, my mistake!

Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
charliermarsh and others added 5 commits January 11, 2024 15:30
@charliermarsh @AlexWaygood
Update CHANGELOG.md
80882b3 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@charliermarsh @AlexWaygood
Update CHANGELOG.md
2a9fb41 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@charliermarsh @AlexWaygood
Update CHANGELOG.md
d300b0b 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@charliermarsh @AlexWaygood
Update CHANGELOG.md
62e01eb 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@charliermarsh @AlexWaygood
Update CHANGELOG.md
dce3d50 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@charliermarsh
Copy link
Copy Markdown
Member Author

charliermarsh commented Jan 11, 2024

Thanks @AlexWaygood, sloppy work on my part, appreciate it :)

zanieb
zanieb approved these changes Jan 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

AlexWaygood
AlexWaygood approved these changes Jan 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Hyped to use some of these in my projects

Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
@charliermarsh @AlexWaygood
Update CHANGELOG.md
42de6fc 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@charliermarsh charliermarsh enabled auto-merge (squash) January 11, 2024 20:43
@charliermarsh @AlexWaygood
Update CHANGELOG.md
97702d9 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@charliermarsh charliermarsh added the release Related to the release process label Jan 11, 2024
@charliermarsh charliermarsh merged commit 55f8f3b into main Jan 11, 2024
@charliermarsh charliermarsh deleted the charlie/bump branch January 11, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanieb zanieb zanieb approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

release Related to the release process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@charliermarsh @zanieb @AlexWaygood