D300: prevent autofix when both triples are in body#8462
Merged
charliermarsh merged 4 commits intoastral-sh:mainfrom Nov 3, 2023
Merged
D300: prevent autofix when both triples are in body#8462charliermarsh merged 4 commits intoastral-sh:mainfrom
D300: prevent autofix when both triples are in body#8462charliermarsh merged 4 commits intoastral-sh:mainfrom
Conversation
Contributor
|
Contributor
Author
|
Sorry for disabling auto-merge, but I think this should have autofix: def contains_triples(t):
'''(\'''|\""")'''Into def contains_triples(t):
"""(\'''|\""")""" |
Member
|
I think this is fine to merge as-is because we already get that "wrong" today for the simpler case, I think: def contains_triples(t):
'''(\""")'''Getting it right requires that we parse the entire docstring to track escapes. |
Contributor
Author
Correct, I was looking for escape-processed of docstring content to implement it, but didn't find a proper way. |
Member
|
@T-256 - We have some stuff like that in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #8402 (comment)
Test Plan
Added associated test