Avoid parenthesizing octal/hex or binary literals in object positions#8160
Merged
MichaReiser merged 1 commit intomainfrom Oct 24, 2023
Merged
Conversation
Member
Author
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
| let text = &source[*range]; | ||
| !matches!( | ||
| text.as_bytes().get(0..2), | ||
| Some([b'0', b'x' | b'X' | b'o' | b'O' | b'b' | b'B']) |
Member
There was a problem hiding this comment.
There can't be any spaces here, right?
Member
Author
There was a problem hiding this comment.
No. Underscores are also not allowed
charliermarsh
approved these changes
Oct 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a Black deviation that is only relevant for unformatted code.
Python (and many other languages) require parenthesizing number literals in the object position of a member expression to disambiguate the
.of the member expression from a decimal separator:However, the parentheses are not required for binary, octal, or hex literals because they can't have a decimal separator
This PR changes our formatter to not insert parentheses for binary, octal, and hex literals.
Test Plan
Fixed black compatibility test.
Verified that the similarity index remains unchanged.