Skip to content

Update RUF100 test to reflect applicability#6877

Merged
zanieb merged 1 commit intomainfrom
fix/ruff-era
Aug 25, 2023
Merged

Update RUF100 test to reflect applicability#6877
zanieb merged 1 commit intomainfrom
fix/ruff-era

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Aug 25, 2023 •
edited
Loading

Broken on merge of #6822 due to new test cases conflicting with the addition of an applicability to RUF100 in #6827

@zanieb zanieb added the internal An internal refactor or improvement label Aug 25, 2023
@zanieb zanieb mentioned this pull request Aug 25, 2023
Merged
konstin
konstin approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just ran into the same thing, thanks

@zanieb zanieb enabled auto-merge (squash) August 25, 2023 16:29
@zanieb zanieb merged commit 0bac7bd into main Aug 25, 2023
@zanieb zanieb deleted the fix/ruff-era branch August 25, 2023 16:58
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2023 •
edited
Loading

PR Check Results

Ecosystem

ℹ️ ecosystem check detected changes. (+6, -0, 0 error(s))

airflow (+4, -0) 

+ airflow/example_dags/tutorial.py:59:9: ERA001 [*] Found commented-out code
+ airflow/example_dags/tutorial.py:60:9: ERA001 [*] Found commented-out code
+ airflow/example_dags/tutorial.py:61:9: ERA001 [*] Found commented-out code
+ airflow/example_dags/tutorial.py:62:9: ERA001 [*] Found commented-out code

zulip (+2, -0) 

+ zerver/lib/push_notifications.py:173:9: ERA001 [*] Found commented-out code
+ zerver/lib/push_notifications.py:174:9: ERA001 [*] Found commented-out code

Rules changed: 1
Rule Changes Additions Removals
ERA001 6 6 0

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      4.5±0.23ms     9.1 MB/sec    1.12      5.0±0.09ms     8.1 MB/sec
formatter/numpy/ctypeslib.py               1.00   886.7±43.74µs    18.8 MB/sec    1.14  1014.0±22.03µs    16.4 MB/sec
formatter/numpy/globals.py                 1.00     90.4±5.45µs    32.7 MB/sec    1.18    106.7±7.81µs    27.7 MB/sec
formatter/pydantic/types.py                1.00  1711.3±76.41µs    14.9 MB/sec    1.11  1903.5±36.16µs    13.4 MB/sec
linter/all-rules/large/dataset.py          1.00      9.9±0.36ms     4.1 MB/sec    1.01     10.0±0.46ms     4.1 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      2.7±0.12ms     6.2 MB/sec    1.12      3.0±0.17ms     5.5 MB/sec
linter/all-rules/numpy/globals.py          1.00   381.6±17.68µs     7.7 MB/sec    1.03   392.9±25.29µs     7.5 MB/sec
linter/all-rules/pydantic/types.py         1.00      5.2±0.22ms     4.9 MB/sec    1.01      5.2±0.23ms     4.9 MB/sec
linter/default-rules/large/dataset.py      1.00      5.4±0.17ms     7.6 MB/sec    1.15      6.2±0.09ms     6.6 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1216.7±58.41µs    13.7 MB/sec    1.10  1344.0±29.50µs    12.4 MB/sec
linter/default-rules/numpy/globals.py      1.00   144.3±12.85µs    20.5 MB/sec    1.08    155.6±3.86µs    19.0 MB/sec
linter/default-rules/pydantic/types.py     1.00      2.4±0.12ms    10.4 MB/sec    1.11      2.7±0.06ms     9.4 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      3.9±0.02ms    10.5 MB/sec    1.00      3.9±0.01ms    10.5 MB/sec
formatter/numpy/ctypeslib.py               1.00    732.5±5.55µs    22.7 MB/sec    1.00    731.1±6.17µs    22.8 MB/sec
formatter/numpy/globals.py                 1.00     65.9±0.75µs    44.8 MB/sec    1.01     66.5±0.59µs    44.4 MB/sec
formatter/pydantic/types.py                1.00  1459.3±16.27µs    17.5 MB/sec    1.01  1466.9±18.26µs    17.4 MB/sec
linter/all-rules/large/dataset.py          1.00      9.9±0.03ms     4.1 MB/sec    1.01      9.9±0.05ms     4.1 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      2.7±0.01ms     6.2 MB/sec    1.00      2.7±0.01ms     6.2 MB/sec
linter/all-rules/numpy/globals.py          1.00    289.2±2.36µs    10.2 MB/sec    1.00    289.5±2.07µs    10.2 MB/sec
linter/all-rules/pydantic/types.py         1.01      5.0±0.02ms     5.1 MB/sec    1.00      5.0±0.02ms     5.1 MB/sec
linter/default-rules/large/dataset.py      1.00      5.5±0.03ms     7.3 MB/sec    1.00      5.5±0.04ms     7.3 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1122.0±5.75µs    14.8 MB/sec    1.00  1118.4±11.09µs    14.9 MB/sec
linter/default-rules/numpy/globals.py      1.00    119.2±0.70µs    24.8 MB/sec    1.01    120.3±1.92µs    24.5 MB/sec
linter/default-rules/pydantic/types.py     1.01      2.4±0.02ms    10.6 MB/sec    1.00      2.4±0.01ms    10.6 MB/sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

@konstin konstin konstin approved these changes

Assignees

No one assigned

Labels

internal An internal refactor or improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zanieb @charliermarsh @konstin