Skip to content

Remove some unnecessary lifetime annotations#5938

Merged
charliermarsh merged 1 commit intomainfrom
charlie/lifetime
Jul 21, 2023
Merged

Remove some unnecessary lifetime annotations#5938
charliermarsh merged 1 commit intomainfrom
charlie/lifetime

Conversation

@charliermarsh
Copy link
Copy Markdown
Member

No description provided.

@charliermarsh charliermarsh added the internal An internal refactor or improvement label Jul 21, 2023
@charliermarsh charliermarsh enabled auto-merge (squash) July 21, 2023 02:37
@charliermarsh charliermarsh merged commit b3d3102 into main Jul 21, 2023
@charliermarsh charliermarsh deleted the charlie/lifetime branch July 21, 2023 02:42
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 21, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00     11.2±0.05ms     3.6 MB/sec    1.00     11.1±0.03ms     3.7 MB/sec
formatter/numpy/ctypeslib.py               1.00      2.2±0.00ms     7.5 MB/sec    1.00      2.2±0.00ms     7.5 MB/sec
formatter/numpy/globals.py                 1.00    246.1±1.26µs    12.0 MB/sec    1.02   251.4±25.43µs    11.7 MB/sec
formatter/pydantic/types.py                1.00      4.8±0.01ms     5.3 MB/sec    1.02      4.9±0.15ms     5.2 MB/sec
linter/all-rules/large/dataset.py          1.00     15.7±0.05ms     2.6 MB/sec    1.00     15.7±0.07ms     2.6 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      4.0±0.01ms     4.2 MB/sec    1.00      4.0±0.01ms     4.2 MB/sec
linter/all-rules/numpy/globals.py          1.01    523.9±1.09µs     5.6 MB/sec    1.00    521.1±0.85µs     5.7 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.1±0.02ms     3.6 MB/sec    1.00      7.1±0.03ms     3.6 MB/sec
linter/default-rules/large/dataset.py      1.01      8.0±0.02ms     5.1 MB/sec    1.00      8.0±0.02ms     5.1 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1701.8±2.93µs     9.8 MB/sec    1.00   1694.6±8.41µs     9.8 MB/sec
linter/default-rules/numpy/globals.py      1.01    189.3±0.54µs    15.6 MB/sec    1.00    187.5±0.32µs    15.7 MB/sec
linter/default-rules/pydantic/types.py     1.01      3.6±0.01ms     7.0 MB/sec    1.00      3.6±0.01ms     7.1 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.01     11.3±0.21ms     3.6 MB/sec    1.00     11.2±0.16ms     3.6 MB/sec
formatter/numpy/ctypeslib.py               1.00      2.2±0.03ms     7.6 MB/sec    1.01      2.2±0.05ms     7.6 MB/sec
formatter/numpy/globals.py                 1.00    241.0±4.68µs    12.2 MB/sec    1.02   247.0±11.96µs    11.9 MB/sec
formatter/pydantic/types.py                1.00      4.8±0.10ms     5.3 MB/sec    1.00      4.8±0.06ms     5.3 MB/sec
linter/all-rules/large/dataset.py          1.00     15.8±0.23ms     2.6 MB/sec    1.00     15.8±0.18ms     2.6 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      4.1±0.08ms     4.0 MB/sec    1.00      4.1±0.05ms     4.1 MB/sec
linter/all-rules/numpy/globals.py          1.00   497.3±12.89µs     5.9 MB/sec    1.00    496.5±9.36µs     5.9 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.1±0.12ms     3.6 MB/sec    1.00      7.1±0.10ms     3.6 MB/sec
linter/default-rules/large/dataset.py      1.01      8.2±0.13ms     4.9 MB/sec    1.00      8.2±0.08ms     5.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1697.9±21.01µs     9.8 MB/sec    1.00  1697.2±26.56µs     9.8 MB/sec
linter/default-rules/numpy/globals.py      1.00    192.4±3.48µs    15.3 MB/sec    1.00    192.9±5.30µs    15.3 MB/sec
linter/default-rules/pydantic/types.py     1.01      3.6±0.08ms     7.0 MB/sec    1.00      3.6±0.06ms     7.1 MB/sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant