Refine a few agents instructions#25423
Merged
Merged
Conversation
charliermarsh
approved these changes
May 27, 2026
| - **Salsa incrementality (ty):** Any method that accesses `.node()` must be `#[salsa::tracked]`, or it will break incrementality. Prefer higher-level semantic APIs over raw AST access. | ||
| - Run `cargo dev generate-all` after changing configuration options, CLI arguments, lint rules, or environment variable definitions, as these changes require regeneration of schemas, docs, and CLI references. | ||
| - Don't prefix tests with `test_`. | ||
| - Don't separate struct definitions from their impl blocks. |
Member
There was a problem hiding this comment.
Worried about this because we do it intentionally in ty in a few places, specifically by splitting impl blocks for builder.rs and stuff into multiple files.
Member
Author
There was a problem hiding this comment.
Any suggestions how to phrase this instead. WHat I've observed is that codex loves to do
struct A{}
< Codex inserts new struct and impl block here >
impl A {}
Member
There was a problem hiding this comment.
Yeah totally agree. I might just add something like "unless the impl is deliberately placed in a separate file, as for large structs".
MichaReiser
commented
May 27, 2026
anishgirianish
pushed a commit
to anishgirianish/ruff
that referenced
this pull request
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.