Skip to content

Add agent skills for working on ty#25422

Merged
AlexWaygood merged 2 commits into
mainfrom
add-agent-skills
May 27, 2026
Merged

Add agent skills for working on ty#25422
AlexWaygood merged 2 commits into
mainfrom
add-agent-skills

Conversation

@AlexWaygood

Copy link
Copy Markdown
Member

Summary

This PR adds a .agents/skills directory to the repo, and adds three skills to help agents work on ty more effectively:

  • A skill to help them write better ty diagnostics
  • A skill to help them minimize a single ecosystem change more effectively
  • A skill to help them analyze and summarise ecosystem reports more effectively

The skills have been designed so that they will (hopefully) work well whether a contributor is using Codex or Claude as their agent locally. Codex should discover these skills automatically if you're working on the repo; if you use Claude locally, you should hopefully be prompted by Claude to install the local skills due to them being listed as recommended skills in .claude/settings.json.

Test Plan

I ran /review locally with Codex, instructing it to be as nitpicky as possible, until it could find no more issues with these skills.

@AlexWaygood AlexWaygood added internal An internal refactor or improvement ty Multi-file analysis & type inference labels May 27, 2026

@carljm carljm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to evaluate all the Claude JSON stuff, but the skills themselves look good to me, and I'd find them useful. Thank you!

@AlexWaygood AlexWaygood merged commit 7e1bc1e into main May 27, 2026
44 checks passed
@AlexWaygood AlexWaygood deleted the add-agent-skills branch May 27, 2026 21:02
anishgirianish pushed a commit to anishgirianish/ruff that referenced this pull request May 28, 2026
## Summary

This PR adds a `.agents/skills` directory to the repo, and adds three
skills to help agents work on ty more effectively:
- A skill to help them write better ty diagnostics
- A skill to help them minimize a single ecosystem change more
effectively
- A skill to help them analyze and summarise ecosystem reports more
effectively

The skills have been designed so that they will (hopefully) work well
whether a contributor is using Codex or Claude as their agent locally.
Codex should discover these skills automatically if you're working on
the repo; if you use Claude locally, you _should_ hopefully be prompted
by Claude to install the local skills due to them being listed as
recommended skills in `.claude/settings.json`.

## Test Plan

I ran `/review` locally with Codex, instructing it to be as nitpicky as
possible, until it could find no more issues with these skills.
AlexWaygood added a commit that referenced this pull request May 29, 2026
## Summary

A bunch of followup changes from
#25422. Mostly triggered by using
the skill for the first time to analyze the report in
#24761.

- Move ty-specific guidance from `AGENTS.md` to a new local
`working-on-ty` skill. Link to the other ty-specific skills from that
skill.
- Add more keyword triggers to various skills so that agents are more
likely to automatically figure out that a skill is appropriate
(suggested by @dhruvmanila).
- Add more guidance to the ecosystem-minimization skill (and tweak the
script for setting up a primer project) so that agents are likely to
reproduce results in a deterministic and helpful way.

## Test Plan

I repeatedly ran `/review` with Codex on this until the only remaining
issues were trivial.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants