[ty] Show type alias value on hover#25381
Merged
MichaReiser merged 21 commits intoJun 4, 2026
Merged
Conversation
MichaReiser
reviewed
May 28, 2026
MichaReiser
left a comment
Member
There was a problem hiding this comment.
I'm still looking into how to handle legacy type aliases, but here some initial feedback.
Member
|
After some discussion, I think we should skip support for legacy implicit type aliases for now, as there's no easy way in our model to detect those |
MichaReiser
reviewed
Jun 1, 2026
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 92.13%. The percentage of expected errors that received a diagnostic held steady at 87.18%. The number of fully passing files held steady at 92/134. |
Memory usage reportMemory usage unchanged ✅ |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds more detail to hovering PEP695 type definitions
Closes astral-sh/ty#1477
I did not manage to get implicit type aliases working here, I had trouble figuring out how to differentiate a type alias from any other static class, e.g
Nor did I exactly follow suite with the hover format for class variable annotations, as I had trouble with differentiating a class variable/field (
a: Ushould hover asa: U (int)) to an actual assignment expression (A = U). Any help with these issues would be much appreciated 😄Test Plan
I added unit tests and tested manually