[ty] Modernize setup of union types in mdtests#25291
Merged
Merged
Conversation
sharkdp
commented
May 21, 2026
sharkdp
commented
May 21, 2026
sharkdp
commented
May 21, 2026
sharkdp
commented
May 21, 2026
sharkdp
commented
May 21, 2026
sharkdp
commented
May 21, 2026
sharkdp
commented
May 21, 2026
sharkdp
commented
May 21, 2026
sharkdp
commented
May 21, 2026
sharkdp
commented
May 21, 2026
sharkdp
commented
May 21, 2026
sharkdp
commented
May 21, 2026
AlexWaygood
approved these changes
May 21, 2026
thejchap
pushed a commit
to thejchap/ruff
that referenced
this pull request
May 23, 2026
Remember when we wrote `x = 1 if flag else None` because we couldn't infer types from annotated parameters and/or couldn't understand union type annotations? This PR modernizes our mdtests to simply use annotated function parameters in those cases (I manually rejected some rewrites when the new style was less clear, for example when the generated union type itself was hard to spell). The motivation for this is to set a better precedent for agents, as I've seen them repeating that `x if flag else y` pattern, which is really unnecessary, longer and harder to read in most cases.
anishgirianish
pushed a commit
to anishgirianish/ruff
that referenced
this pull request
May 28, 2026
Remember when we wrote `x = 1 if flag else None` because we couldn't infer types from annotated parameters and/or couldn't understand union type annotations? This PR modernizes our mdtests to simply use annotated function parameters in those cases (I manually rejected some rewrites when the new style was less clear, for example when the generated union type itself was hard to spell). The motivation for this is to set a better precedent for agents, as I've seen them repeating that `x if flag else y` pattern, which is really unnecessary, longer and harder to read in most cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remember when we wrote
x = 1 if flag else Nonebecause we couldn't infer types from annotated parameters and/or couldn't understand union type annotations? This PR modernizes our mdtests to simply use annotated function parameters in those cases (I manually rejected some rewrites when the new style was less clear, for example when the generated union type itself was hard to spell).The motivation for this is to set a better precedent for agents, as I've seen them repeating that
x if flag else ypattern, which is really unnecessary, longer and harder to read in most cases.