Set exclude-newer = "7 days" in our PEP-723 scripts#25285
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 89.36%. The percentage of expected errors that received a diagnostic held steady at 85.49%. The number of fully passing files held steady at 88/134. |
Memory usage reportMemory usage unchanged ✅ |
|
|
EliteTK
approved these changes
May 21, 2026
6b41284 to
d1c1890
Compare
thejchap
pushed a commit
to thejchap/ruff
that referenced
this pull request
May 23, 2026
## Summary This helps reduce spurious changes to the lockfile if you run these scripts on a machine that has a global `exclude-newer` value set in a `~/.config/uv.toml` file or similar. It also seems good more generally to set an `exclude-newer` value for these scripts: dependency cooldowns are better for security. Note that if the machine, hypothetically, also set `UV_DEFAULT_INDEX` as an environment variable to something other than `pypi.org/simple`, there would still be changes to the lockfile, so this change may be necessary but not sufficient for lockfile stability on _certain_ corporate machines. ## Test Plan I ensured that the `UV_DEFAULT_INDEX` environment variable was set to `pypi.org/simple` on my machine and then ran `mdtest.py` using `uv run`. I didn't run `setup_primer_project.py`, but I did lock it using `uv lock --script`.
anishgirianish
pushed a commit
to anishgirianish/ruff
that referenced
this pull request
May 28, 2026
## Summary This helps reduce spurious changes to the lockfile if you run these scripts on a machine that has a global `exclude-newer` value set in a `~/.config/uv.toml` file or similar. It also seems good more generally to set an `exclude-newer` value for these scripts: dependency cooldowns are better for security. Note that if the machine, hypothetically, also set `UV_DEFAULT_INDEX` as an environment variable to something other than `pypi.org/simple`, there would still be changes to the lockfile, so this change may be necessary but not sufficient for lockfile stability on _certain_ corporate machines. ## Test Plan I ensured that the `UV_DEFAULT_INDEX` environment variable was set to `pypi.org/simple` on my machine and then ran `mdtest.py` using `uv run`. I didn't run `setup_primer_project.py`, but I did lock it using `uv lock --script`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This helps reduce spurious changes to the lockfile if you run these scripts on a machine that has a global
exclude-newervalue set in a~/.config/uv.tomlfile or similar. It also seems good more generally to set anexclude-newervalue for these scripts: dependency cooldowns are better for security.Note that if the machine, hypothetically, also set
UV_DEFAULT_INDEXas an environment variable to something other thanpypi.org/simple, there would still be changes to the lockfile, so this change may be necessary but not sufficient for lockfile stability on certain corporate machines.Test Plan
I ensured that the
UV_DEFAULT_INDEXenvironment variable was set topypi.org/simpleon my machine and then ranmdtest.pyusinguv run. I didn't runsetup_primer_project.py, but I did lock it usinguv lock --script.