[ty] Autocomplete arguments if in arguments node#24167
Merged
MichaReiser merged 2 commits intoastral-sh:mainfrom Mar 26, 2026
Merged
[ty] Autocomplete arguments if in arguments node#24167MichaReiser merged 2 commits intoastral-sh:mainfrom
MichaReiser merged 2 commits intoastral-sh:mainfrom
Conversation
2f2828b to
5c78e03
Compare
MichaReiser
reviewed
Mar 25, 2026
| } | ||
| ast::AnyNodeRef::ExprCall(call) => { | ||
| if call.arguments.range().contains_range(cursor.range) { | ||
| if in_arguments && call.arguments.range().contains_range(cursor.range) { |
Member
There was a problem hiding this comment.
Do we still need the contains_range check`?
Contributor
Author
There was a problem hiding this comment.
From the code looks like it's not needed, tests pass too and I tested the lsp locally and it works without it.
7478f30 to
a760335
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses this comment.
Fixes astral-sh/ty#3087.
I initially did the same ancestor walking check in both places but then I tried to come up with another way that does not iterate multiple times.
Since in
add_argument_completionswe are already iterating over node ancestors of the node the cursor is in, we can determine if cursor is in an arguments node.So I did that instead of duplicating the
cursor.covering_node.ancestors() ...code.Test Plan
Added the test case that would panic in debug build without this fix.