[ty] Implement Python's floor division semantics for Literal ints#18249
Merged
carljm merged 3 commits intoastral-sh:mainfrom May 22, 2025
Merged
[ty] Implement Python's floor division semantics for Literal ints#18249carljm merged 3 commits intoastral-sh:mainfrom
Literal ints#18249carljm merged 3 commits intoastral-sh:mainfrom
Conversation
Literal intsLiteral ints
Contributor
|
carljm
approved these changes
May 22, 2025
Contributor
carljm
left a comment
There was a problem hiding this comment.
Looks good! Verified the asserted results in tests match actual runtime results, and the code looks right. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Division works differently in Python than in Rust. If the result is negative and there is a remainder, the division rounds down (instead of towards zero). The remainder needs to be adjusted to compensate so that
(lhs // rhs) * rhs + (lhs % rhs) == lhs.Fixes astral-sh/ty#481. @AlexWaygood.