Skip to content

[ty] Clarify ty check output default in documentation.#18246

Merged
MichaReiser merged 2 commits intoastral-sh:mainfrom
brainwane:cli-ty
May 22, 2025
Merged

[ty] Clarify ty check output default in documentation.#18246
MichaReiser merged 2 commits intoastral-sh:mainfrom
brainwane:cli-ty

Conversation

@brainwane
Copy link
Contributor

Summary

Add a "[default]" note in the CLI documentation to indicate that, by default, ty check prints "full" diagnostic output, not "concise" output.

Was: astral-sh/ty#478 .

Test Plan

I pushed the branch, and read the preview of the Markdown file on GitHub in my browser.

@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2025

mypy_primer results

No ecosystem changes detected ✅

@carljm
Copy link
Contributor

carljm commented May 21, 2025

@MichaReiser This seems like useful information for users to have in the command reference; should we just add it in the comment at

/// annotations on the input to help understand the message.
, or is there a way to update the script so that we automatically output this in the reference based on the existing [#default] annotation?

@AlexWaygood AlexWaygood added the documentation Improvements or additions to documentation label May 21, 2025
@MichaReiser
Copy link
Member

, or is there a way to update the script so that we automatically output this in the reference based on the existing [#default] annotation?

This seems hard because it requires understanding Rust code. But yes, we should update the docs comment in args.rs and then run cargo dev generate-all to generate the docs.

@brainwane brainwane marked this pull request as draft May 22, 2025 09:49
@MichaReiser MichaReiser added the ty Multi-file analysis & type inference label May 22, 2025
@MichaReiser
Copy link
Member

Thanks

@MichaReiser MichaReiser marked this pull request as ready for review May 22, 2025 13:24
@MichaReiser MichaReiser merged commit 029085f into astral-sh:main May 22, 2025
35 checks passed
@brainwane brainwane deleted the cli-ty branch May 22, 2025 15:44
sharkdp pushed a commit to astral-sh/ty that referenced this pull request May 23, 2025
…490)

## Summary

Explain in `CONTRIBUTING.md` that some ty help text and reference
documentation result from source code that lives in Ruff, and point to
sources, to help tech writer contributors.

Inspired by my stumble in #478 and subsequent pointers in
astral-sh/ruff#18246 .

## Test Plan

I used `git grep` to search the Ruff repository for several chunks of
the prose in `docs/reference/` to verify which source code contains text
that turns into the autogenerated docs. I pushed my branch to GitHub and
manually checked that the formatting and hyperlinks were correct.
epitech314 added a commit to epitech314/ty that referenced this pull request Nov 12, 2025
…#490)

## Summary

Explain in `CONTRIBUTING.md` that some ty help text and reference
documentation result from source code that lives in Ruff, and point to
sources, to help tech writer contributors.

Inspired by my stumble in #478 and subsequent pointers in
astral-sh/ruff#18246 .

## Test Plan

I used `git grep` to search the Ruff repository for several chunks of
the prose in `docs/reference/` to verify which source code contains text
that turns into the autogenerated docs. I pushed my branch to GitHub and
manually checked that the formatting and hyperlinks were correct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants