Improve internal docs for various string-node APIs#16256
Merged
AlexWaygood merged 2 commits intomainfrom Feb 19, 2025
Merged
Conversation
Contributor
|
ntBre
approved these changes
Feb 19, 2025
Contributor
ntBre
left a comment
There was a problem hiding this comment.
Nice, this looks great! The is_empty clarification seems especially helpful.
I actually slightly prefer the Returns an iterator phrasing, but I don't feel too strongly about it.
Member
Author
Ah fair enough, I'll revert those changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A fairly minor PR touching up some internal docs, since I've been looking at these methods a lot recently