[red-knot] Fix diagnostic range for non-iterable unpacking assignments#15994
Merged
[red-knot] Fix diagnostic range for non-iterable unpacking assignments#15994
Conversation
MichaReiser
approved these changes
Feb 6, 2025
Comment on lines
+24
to
+25
| 1 | a, b = (1,) # error: [invalid-assignment] | ||
| | ^^^^ Not enough values to unpack (expected 2, got 1) |
Member
There was a problem hiding this comment.
This is probably a case where we'd want multiple diagnostic ranges (@BurntSushi) but having the assignment target being the main range seems correct.
Contributor
Author
There was a problem hiding this comment.
Yes, I just included these here to make sure that we're not generally moving the diagnostic range to the right hand side of the assignment. Just for this very specific case I fixed (where unwrap_diagnostic_range really expects the expression of the iterable, not the assignment target).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that the diagnostic range in specific unpacking assignments is wrong. For this example
we previously got (see first commit):
and with this change, we get:
Test Plan
New snapshot tests.