Skip to content

[red-knot] Minor refactor of red_knot_vendored/build.rs#15372

Merged
sharkdp merged 1 commit intomainfrom
david/zip-typeshed-dir
Jan 9, 2025
Merged

[red-knot] Minor refactor of red_knot_vendored/build.rs#15372
sharkdp merged 1 commit intomainfrom
david/zip-typeshed-dir

Conversation

@sharkdp
Copy link
Contributor

@sharkdp sharkdp commented Jan 9, 2025

Summary

See #15370 (comment):

  • Rename zip_dir to write_zipped_typeshed_to to clarify it's not a generic function (anymore)
  • Hard-code TYPESHED_SOURCE_DIR instead of using a directory_path argument

@sharkdp sharkdp added the ty Multi-file analysis & type inference label Jan 9, 2025
@sharkdp sharkdp added the internal An internal refactor or improvement label Jan 9, 2025
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@sharkdp sharkdp enabled auto-merge (squash) January 9, 2025 12:21
@sharkdp sharkdp merged commit bf5b0c2 into main Jan 9, 2025
@sharkdp sharkdp deleted the david/zip-typeshed-dir branch January 9, 2025 12:23
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants