[red-knot] Remove unneeded branch in Type::is_equivalent_to()#15242
Merged
AlexWaygood merged 1 commit intomainfrom Jan 3, 2025
Merged
[red-knot] Remove unneeded branch in Type::is_equivalent_to()#15242AlexWaygood merged 1 commit intomainfrom
Type::is_equivalent_to()#15242AlexWaygood merged 1 commit intomainfrom
Conversation
Contributor
|
MichaReiser
approved these changes
Jan 3, 2025
sharkdp
approved these changes
Jan 3, 2025
Contributor
sharkdp
left a comment
There was a problem hiding this comment.
I removed an earlier version of this check in my statically-known-branches PR, but probably missed this during a rebase. The early-return-version of is_equivalent_to arrived at some point when that PR was open, IIRC. Anyway, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We understand
sys.version_infobranches now! As such, I believe this branch is no longer required; all tests pass without it. I also ranQUICKCHECK_TESTS=100000 cargo test -p red_knot_python_semantic -- --ignored types::property_tests::stable, and no tests failed except for the known issue withType::is_assignable_to()(#14899)Test Plan
See above