Avoids unnecessary overhead for TC004, when TC001-003 are disabled#14657
Merged
MichaReiser merged 2 commits intoastral-sh:mainfrom Nov 28, 2024
Merged
Conversation
Contributor
|
We still shouldn't run TC004 in stub files, it won't ever cause violations so we do a whole bunch of work for nothing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Another minor thing that came up as part of #12927
TC004 doesn't use the
runtime_importsvector we're building during analysis of deferred scopes, so we don't need to do that work when it's the only typing import rule that is enabled.Test Plan
cargo nextest run