[red-knot] Infer precise types for `len()` calls by InSyncWithFoo · Pull Request #14599 · astral-sh/ruff

InSyncWithFoo · 2024-11-26T04:55:15Z

Summary

Resolves #14598.

Test Plan

Markdown tests.

github-actions · 2024-11-26T05:01:29Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

crates/red_knot_python_semantic/src/types.rs

carljm

Thank you!! A few comments.

crates/red_knot_python_semantic/resources/mdtest/expression/len.md

crates/red_knot_python_semantic/src/types.rs

AlexWaygood

Thanks!

crates/red_knot_python_semantic/src/types.rs

crates/red_knot_python_semantic/src/types/unpacker.rs

crates/red_knot_python_semantic/src/types.rs

crates/red_knot_python_semantic/resources/mdtest/expression/len.md

crates/red_knot_python_semantic/src/types.rs

carljm

This looks quite close! Thanks for your patience with all the review comments.

I think it makes sense to leave the diagnostics as TODO here, because it will be a lot easier to emit these diagnostics once #14760 lands (we won't have to return some indicator such that inference emits the diagnostic, we'll be able to just emit it directly where we find the issue.)

crates/red_knot_python_semantic/resources/mdtest/expression/len.md

crates/red_knot_python_semantic/src/types.rs

MichaReiser · 2024-12-04T18:30:59Z

@carljm I'm not sure if #14760 will land. It's unclear to me how suppressions would work with accumulators whereas it's clear to me how they would work in our existing model.

carljm · 2024-12-04T18:35:27Z

@MichaReiser Ok, let's discuss those details elsewhere. The only part that's relevant here is to say that I think accumulators will be super useful in type checking and make a lot of things much simpler and easier, so I think we really want/need it, even if it requires more work on handling suppressions.

crates/red_knot_python_semantic/src/types.rs

Looks like all comments in this review were addressed.

carljm · 2024-12-04T19:16:42Z

Thanks! And great find on the string-literal-unpacking issue. Merging.

InSyncWithFoo requested review from AlexWaygood, MichaReiser, carljm and sharkdp as code owners November 26, 2024 04:55

MichaReiser added the ty Multi-file analysis & type inference label Nov 26, 2024

MichaReiser reviewed Nov 26, 2024

View reviewed changes

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

sharkdp reviewed Nov 26, 2024

View reviewed changes

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

sharkdp reviewed Nov 26, 2024

View reviewed changes

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

sharkdp reviewed Nov 26, 2024

View reviewed changes

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

carljm requested changes Nov 26, 2024

View reviewed changes

InSyncWithFoo requested a review from carljm November 27, 2024 08:24

carljm reviewed Nov 28, 2024

View reviewed changes

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

InSyncWithFoo added 2 commits November 28, 2024 17:34

[red-knot] Infer precise types for len() calls

ac422b2

Per review

27db683

InSyncWithFoo force-pushed the rk-len branch from 5420238 to 27db683 Compare November 28, 2024 17:36

AlexWaygood previously requested changes Nov 28, 2024

View reviewed changes

Per review

3c2565b

AlexWaygood reviewed Nov 28, 2024

View reviewed changes

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

Per review

cb53e20

dhruvmanila reviewed Nov 29, 2024

View reviewed changes

crates/red_knot_python_semantic/src/types/unpacker.rs Outdated Show resolved Hide resolved

InSyncWithFoo added 2 commits November 29, 2024 05:34

Add a few Unicode unpacking tests

fde7472

Add another test for \U escape

2210172

AlexWaygood reviewed Nov 29, 2024

View reviewed changes

crates/red_knot_python_semantic/src/types.rs Show resolved Hide resolved

crates/red_knot_python_semantic/resources/mdtest/expression/len.md Outdated Show resolved Hide resolved

InSyncWithFoo added 2 commits November 29, 2024 14:03

Per review

bf775bd

Tests

0ef74b9

AlexWaygood reviewed Nov 29, 2024

View reviewed changes

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

AlexWaygood reviewed Nov 29, 2024

View reviewed changes

crates/red_knot_python_semantic/src/types.rs Show resolved Hide resolved

Per review

db19b03

carljm reviewed Dec 4, 2024

View reviewed changes

InSyncWithFoo added 4 commits December 4, 2024 18:36

Per review

425d740

Merge branch 'main' into rk-len

f7e356e

Rename BytesLiteralType::len

bcf3c83

Method renamed

f084681

carljm reviewed Dec 4, 2024

View reviewed changes

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

carljm reviewed Dec 4, 2024

View reviewed changes

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

Update crates/red_knot_python_semantic/src/types.rs

7a568a1

carljm approved these changes Dec 4, 2024

View reviewed changes

carljm merged commit 155d34b into astral-sh:main Dec 4, 2024

InSyncWithFoo deleted the rk-len branch December 4, 2024 19:29

Conversation

InSyncWithFoo commented Nov 26, 2024

Summary

Test Plan

Uh oh!

github-actions bot commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ruff-ecosystem results

Linter (stable)

Linter (preview)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carljm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carljm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MichaReiser commented Dec 4, 2024

Uh oh!

carljm commented Dec 4, 2024

Uh oh!

Uh oh!

Uh oh!

carljm commented Dec 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions bot commented Nov 26, 2024 •

edited

Loading

`ruff-ecosystem` results