Docs: tweak rules documentation#14180
Merged
MichaReiser merged 2 commits intoastral-sh:mainfrom Nov 8, 2024
Merged
Conversation
097ff87 to
6ae86fa
Compare
Contributor
|
AlexWaygood
reviewed
Nov 7, 2024
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks! Overall this is great!
crates/ruff_linter/src/rules/flake8_bugbear/rules/getattr_with_constant.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_pyi/rules/quoted_annotation_in_stub.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_type_checking/rules/empty_type_checking_block.rs
Outdated
Show resolved
Hide resolved
...es/ruff_linter/src/rules/flake8_type_checking/rules/runtime_import_in_type_checking_block.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_type_checking/rules/typing_only_runtime_import.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_type_checking/rules/typing_only_runtime_import.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_type_checking/rules/typing_only_runtime_import.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/pyupgrade/rules/unnecessary_default_type_args.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/pyupgrade/rules/unnecessary_default_type_args.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_annotations/rules/definition.rs
Outdated
Show resolved
Hide resolved
6ae86fa to
36c2e97
Compare
Contributor
Author
|
Thanks for the quick comments @AlexWaygood |
36c2e97 to
d4677e7
Compare
sbrugman
commented
Nov 8, 2024
crates/ruff_linter/src/rules/flake8_type_checking/rules/typing_only_runtime_import.rs
Outdated
Show resolved
Hide resolved
d4677e7 to
e0912bb
Compare
AlexWaygood
approved these changes
Nov 8, 2024
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks, looks great! Just two more nits:
crates/ruff_linter/src/rules/flake8_bandit/rules/suspicious_imports.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_annotations/rules/definition.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found these while experimenting with the categorisation:
https://peps.python.org/instead ofhttps://www.python.org/dev/)PEP [code] - [page title]PEP [code]: [section title]