Remove allow-unused-imports setting from the common lint options#13677
Merged
MichaReiser merged 3 commits intoruff-0.7from Oct 8, 2024
Merged
Conversation
Contributor
|
AlexWaygood
approved these changes
Oct 8, 2024
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
LGTM as part of a minor release (which it will be!)
zanieb
approved these changes
Oct 8, 2024
AlexWaygood
pushed a commit
that referenced
this pull request
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13668
Luckily, the
lint.allow_unused_importssetting isn't read anywhere.However, this could still be considered a breaking change because Ruff might fail to read a previously valid configuration.
I do think that it should be very unlikely, considering that the configuration was "useless" before.
The setting remains available under
lint.pyflakesruff/crates/ruff_workspace/src/options.rs
Lines 2824 to 2829 in 0035ca9
Test Plan
cargo test