Use backticks for code in red-knot messages#13599
Merged
charliermarsh merged 2 commits intomainfrom Oct 2, 2024
Merged
Conversation
409733b to
06c1744
Compare
Member
Author
|
I might also suggest removing periods from the end of these error messages (unless they span more than one sentence). We use that policy in uv and in Ruff. |
carljm
approved these changes
Oct 2, 2024
Contributor
carljm
left a comment
There was a problem hiding this comment.
Thanks!
I have no problem with removing final periods, in this PR or another one; it makes sense to have a consistent style guide across projects.
Contributor
|
Looks like there's one missed test to fix. |
Member
Author
|
Sounds good. I'll probably just bundle it here then to reduce churn (fewer commits to ignore when git blaming). |
5e35760 to
d82e2b3
Compare
Contributor
|
d82e2b3 to
678e651
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
...and remove periods from messages that don't span more than a single sentence.
This is more consistent with how we present user-facing messages in uv (which has a defined style guide).