[red-knot] Fix type inference for except* definitions#13320
Merged
AlexWaygood merged 2 commits intomainfrom Sep 11, 2024
Merged
[red-knot] Fix type inference for except* definitions#13320AlexWaygood merged 2 commits intomainfrom
except* definitions#13320AlexWaygood merged 2 commits intomainfrom
Conversation
Contributor
|
MichaReiser
reviewed
Sep 10, 2024
carljm
reviewed
Sep 10, 2024
00477d2 to
42c3085
Compare
MichaReiser
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once again, async Python requires different inference rules to sync Python!
A new
DefinitionNodeRef::ExceptStarHandlervariant is introduced, so that we can differentiate between except-handler definitions inStmtTry { is_star: true }nodes and those inStmtTry { is_star: false }nodes. The logic for adding these definitions is also moved inbuilder.rsso that we can know whether thetryblock is catching exceptions or exception groups. (We'll need to move the logic there anyway when adding control flow for these definitions.)Lots of TODOs here, but I think inferring
Instance(BaseExceptionGroup)is better than just inferringUnknownfor these definitions.The PR is stacked on top of #13319