Skip to content

Make mypy pass on black in knot_benchmark#13235

Merged
AlexWaygood merged 2 commits intomainfrom
alex/black-bench
Sep 4, 2024
Merged

Make mypy pass on black in knot_benchmark#13235
AlexWaygood merged 2 commits intomainfrom
alex/black-bench

Conversation

@AlexWaygood
Copy link
Copy Markdown
Member

@AlexWaygood AlexWaygood commented Sep 3, 2024

Summary

This fixes one of the problems highlighted in astral-sh/ty#241 in the knot_benchmark script. The issue was that recent versions of aiohttp led to typing errors in black. These were fixed in psf/black@699b45a, but we pinned a commit of black prior to that in knot_benchmark; meanwhile, we were installing the latest version of aiohttp, because our dependencies for the projects being benchmarked were not pinned.

This PR bumps the pinned commit of black to a newer version, and adds a --exclude-newer flag (set to today's date) to the installation command so that we won't be impacted by issues like this in the future.

Test Plan

~/dev/ruff/scripts/knot_benchmark (alex/black-bench)⚡ % uv run benchmark --project=black -vv --mypy --min-runs=1 --benchmark cold
2024-09-03 21:02:05 INFO Cloned black to /var/folders/gd/1czdxc454j15y8gns2krv8vc0000gn/T/tmp35jq5s6j.
black (cold)
2024-09-03 21:02:05 INFO Running ['hyperfine', '-i', '--show-output', '--warmup', '3', '--min-runs', '1', '--command-name', 'mypy', '--prepare', '', '/Users/alexw/dev/ruff/scripts/knot_benchmark/.venv/bin/mypy --python-executable /var/folders/gd/1czdxc454j15y8gns2krv8vc0000gn/T/tmp35jq5s6j/venv/bin/python src --no-incremental --cache-dir /dev/null']
Benchmark 1: mypy
Warning: unused section(s) in pyproject.toml: module = ['tests.data.*']
Success: no issues found in 40 source files
Warning: unused section(s) in pyproject.toml: module = ['tests.data.*']
Success: no issues found in 40 source files
Warning: unused section(s) in pyproject.toml: module = ['tests.data.*']
Success: no issues found in 40 source files
Warning: unused section(s) in pyproject.toml: module = ['tests.data.*']
Success: no issues found in 40 source files
Warning: unused section(s) in pyproject.toml: module = ['tests.data.*']
Success: no issues found in 40 source files
  Time (mean ± σ):      1.485 s ±  0.012 s    [User: 1.398 s, System: 0.084 s]
  Range (min … max):    1.476 s …  1.493 s    2 runs

@AlexWaygood AlexWaygood added the ty Multi-file analysis & type inference label Sep 3, 2024
@AlexWaygood AlexWaygood mentioned this pull request Sep 3, 2024
Closed
MichaReiser
MichaReiser approved these changes Sep 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

MichaReiser
MichaReiser reviewed Sep 4, 2024
View reviewed changes
@AlexWaygood AlexWaygood enabled auto-merge (squash) September 4, 2024 09:31
@AlexWaygood AlexWaygood merged commit 5728909 into main Sep 4, 2024
@AlexWaygood AlexWaygood deleted the alex/black-bench branch September 4, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

@carljm carljm carljm approved these changes

Assignees

No one assigned

Labels

ty Multi-file analysis & type inference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexWaygood @carljm @MichaReiser