Skip to content

[red-knot] Add debug assert to check for duplicate definitions#13214

Merged
dhruvmanila merged 1 commit intomainfrom
dhruv/assert-duplicate-definitions
Sep 4, 2024
Merged

[red-knot] Add debug assert to check for duplicate definitions#13214
dhruvmanila merged 1 commit intomainfrom
dhruv/assert-duplicate-definitions

Conversation

@dhruvmanila
Copy link
Copy Markdown
Member

@dhruvmanila dhruvmanila commented Sep 2, 2024

Summary

Closes: #13085

Test Plan

cargo insta test --workspace

@dhruvmanila dhruvmanila added the ty Multi-file analysis & type inference label Sep 2, 2024
@dhruvmanila dhruvmanila marked this pull request as ready for review September 2, 2024 12:52
@AlexWaygood AlexWaygood removed their request for review September 2, 2024 13:42
@dhruvmanila dhruvmanila force-pushed the dhruv/assert-duplicate-definitions branch from d88c0cc to 84b577e Compare September 3, 2024 05:30
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 3, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Base automatically changed from dhruv/comprehension-multiple-target to main September 4, 2024 05:49
@dhruvmanila dhruvmanila force-pushed the dhruv/assert-duplicate-definitions branch from 84b577e to e672eff Compare September 4, 2024 05:49
@dhruvmanila dhruvmanila enabled auto-merge (squash) September 4, 2024 05:51
@dhruvmanila dhruvmanila merged commit 862bd0c into main Sep 4, 2024
@dhruvmanila dhruvmanila deleted the dhruv/assert-duplicate-definitions branch September 4, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[red-knot] assert that we don't create multiple definitions for one node

3 participants