Make ruff_db a required crate for ruff_python_semantic#11874
Merged
MichaReiser merged 1 commit intomainfrom Jun 14, 2024
Merged
Make ruff_db a required crate for ruff_python_semantic#11874MichaReiser merged 1 commit intomainfrom
ruff_db a required crate for ruff_python_semantic#11874MichaReiser merged 1 commit intomainfrom
Conversation
CodSpeed Performance ReportMerging #11874 will degrade performances by 11.77%Comparing Summary
Benchmarks breakdown
|
MichaReiser
approved these changes
Jun 14, 2024
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the
ruff_dba required crate forruff_python_semantic.Refer https://github.com/astral-sh/ruff/actions/runs/9516626143/job/26233307158?pr=11872
Test Plan
maturin sdist --out disttar -xf dist/ruff-0.4.8.tar.gz --directory=dist/ruff-0.4.8pip install dist/ruff-0.4.8.tar.gzworks