Skip to content

Update type annotation parsing API to return Parsed#11739

Merged
dhruvmanila merged 1 commit intomainfrom
dhruv/type-annotation-parsed
Jun 5, 2024
Merged

Update type annotation parsing API to return Parsed#11739
dhruvmanila merged 1 commit intomainfrom
dhruv/type-annotation-parsed

Conversation

@dhruvmanila
Copy link
Copy Markdown
Member

Summary

This PR updates the return type of parse_type_annotation from Expr to Parsed<ModExpression>. This is to allow accessing the tokens for the parsed sub-expression in the follow-up PR.

Test Plan

cargo insta test

@dhruvmanila dhruvmanila added the internal An internal refactor or improvement label Jun 4, 2024
@dhruvmanila dhruvmanila requested a review from MichaReiser as a code owner June 4, 2024 16:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 4, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@dhruvmanila dhruvmanila merged commit eed6d78 into main Jun 5, 2024
@dhruvmanila dhruvmanila deleted the dhruv/type-annotation-parsed branch June 5, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants